labath added a comment.

Yes, I think that's exactly what I had in mind. Basically, the idea is to 
structure things such that the ondemand class can sit between the actual symbol 
file class and the outside world, but that it does not (and cannot) interfere 
with any of the interactions that happen inside a symbol file class. If it 
works, I think that kind of a setup would be much cleaner/understandable. As it 
stands now, one has to consider the possibility that any action inside the real 
symbol file can reenter the ondemand instance, which makes it harder to reason 
about.

I definitely wouldn't want to do it as a part of this patch, but it would be 
better to do it as a preparatory patch rather than a followup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121631/new/

https://reviews.llvm.org/D121631

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to