mstorsjo added a reviewer: labath.
mstorsjo added inline comments.
================
Comment at: lldb/tools/lldb-vscode/OutputRedirector.cpp:12
+#else
+#include <fcntl.h>
+#include <io.h>
----------------
Minor style issue - I guess it'd be less of double negation, if we'd change the
ifdef to `#if defined(_WIN32) .. #else`
================
Comment at: lldb/tools/lldb-vscode/OutputRedirector.cpp:55
}
- callback(StringRef(buffer, bytes_count).str());
+ callback(StringRef(buffer, bytes_count));
}
----------------
This change looks unrelated (although I'm not familiar with this piece of
code), although it's probably correct
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123025/new/
https://reviews.llvm.org/D123025
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
