jasonmolenda added inline comments.

================
Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:588
+  stream.str(std::string());
+  stream.clear();
   return SendPacket(payload);
----------------
JDevlieghere wrote:
> `clear` doesn't do what you think it does, it modifies the state flag which 
> isn't relevant here.
Yeah I know, the common idiom for clearing an ostringstream is to .str("") an 
then .clear() to clear flag state, I was only clear'ing to be proper, even 
though we don't use the object past this point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122848/new/

https://reviews.llvm.org/D122848

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to