This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG826bdf51ff31: [lldb] Fix llvm::Optional summary provider (authored by kastiglione).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122041/new/ https://reviews.llvm.org/D122041 Files: llvm/utils/lldbDataFormatters.py Index: llvm/utils/lldbDataFormatters.py =================================================================== --- llvm/utils/lldbDataFormatters.py +++ llvm/utils/lldbDataFormatters.py @@ -138,7 +138,11 @@ def OptionalSummaryProvider(valobj, internal_dict): val = GetOptionalValue(valobj) - return val.summary if val else 'None' + if val is None: + return 'None' + if val.summary: + return val.summary + return '' class OptionalSynthProvider: """Provides deref support to llvm::Optional<T>"""
Index: llvm/utils/lldbDataFormatters.py =================================================================== --- llvm/utils/lldbDataFormatters.py +++ llvm/utils/lldbDataFormatters.py @@ -138,7 +138,11 @@ def OptionalSummaryProvider(valobj, internal_dict): val = GetOptionalValue(valobj) - return val.summary if val else 'None' + if val is None: + return 'None' + if val.summary: + return val.summary + return '' class OptionalSynthProvider: """Provides deref support to llvm::Optional<T>"""
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits