mib marked an inline comment as done. mib added inline comments.
================ Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1624 +# ================================================== +# Utility class to setup a progress event listener +# ================================================== ---------------- JDevlieghere wrote: > We should make this more generic so that the warning and error events can > also use this. The way I imagined this was that the thread would be generic > and you would pass it in the broadcaster, the listener and the event type and > finally a function callback to have the test do whatever it wants with the > event. @JDevlieghere I think this could be achieved very easily by assuming the `_fetch_events` method will always be called and replace the `callback` argument by a "pointer" to the event_data_extractor function. wdyk ?' Do you think it's a fair assumption (that we should always call `_fetch_events` and match the event against the `src_broadcaster` argument) ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.org/D121977 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
