tmatheson added inline comments.

================
Comment at: llvm/include/llvm/Support/WithColor.h:142
+  /// Retrieve the default color auto detection function.
+  static AutoDetectFunctionType defaultAutoDetectFunction();
+
----------------
This introduces a global constructor call into libSupport, which it should not. 
See https://reviews.llvm.org/rG5eb2e9aa64b7be7cd8ed7f36de19c2c9bdf1977c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120593/new/

https://reviews.llvm.org/D120593

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to