JDevlieghere added inline comments.

================
Comment at: lldb/source/Host/macosx/objcxx/HostThreadMacOSX.mm:17-20
+  NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
+  lldb::thread_result_t result = HostThreadPosix::ThreadCreateTrampoline(arg);
+  [pool drain];
+  return result;
----------------
I believe it's recommended to use an @autoreleasepool block instead of using 
the NSAutoreleasePool directly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120322/new/

https://reviews.llvm.org/D120322

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to