Author: Jim Ingham Date: 2022-02-16T19:10:03-08:00 New Revision: 05f10ae0d8548e65130475730a1565203da8726d
URL: https://github.com/llvm/llvm-project/commit/05f10ae0d8548e65130475730a1565203da8726d DIFF: https://github.com/llvm/llvm-project/commit/05f10ae0d8548e65130475730a1565203da8726d.diff LOG: On Windows, the function name contains the return parameter, so the test has to be "function name contains the name we used to specify the breakpoint" not IS the name... Added: Modified: lldb/test/API/functionalities/breakpoint/breakpoint_on_overload/TestBreakOnOverload.py Removed: ################################################################################ diff --git a/lldb/test/API/functionalities/breakpoint/breakpoint_on_overload/TestBreakOnOverload.py b/lldb/test/API/functionalities/breakpoint/breakpoint_on_overload/TestBreakOnOverload.py index 49d7442f6763..30124f8335d7 100644 --- a/lldb/test/API/functionalities/breakpoint/breakpoint_on_overload/TestBreakOnOverload.py +++ b/lldb/test/API/functionalities/breakpoint/breakpoint_on_overload/TestBreakOnOverload.py @@ -18,7 +18,12 @@ def check_breakpoint(self, name): self.assertEqual(bkpt.num_locations, 1, "Got one location") addr = bkpt.locations[0].GetAddress() self.assertTrue(addr.function.IsValid(), "Got a real function") - self.assertEqual(addr.function.name, name, "Got the right name") + # On Window, the name of the function includes the return value. + # We still succeed in setting the breakpoint, but the resultant + # name is not the same. + # So just look for the name we used for the breakpoint in the + # function name, rather than doing an equality check. + self.assertIn(name, addr.function.name, "Got the right name") def test_break_on_overload(self): self.build() _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
