JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land.
LGTM. From my own notes: - I wrote down that I neede "MSVC C++ x64/x86 build tool". Not sure if that's really required? - As someone who's used to working on the command line, it took me way to long to figure out that I had to run `"%ProgramFiles(x86)%\Microsoft Visual Studio\2019\Community\Common7\Tools\VsDevCmd" -arch=amd64 -host_arch=amd64 -no_logo` before I could do anything useful. Not sure if that's worth mention here as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/ https://reviews.llvm.org/D118425 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
