JDevlieghere added inline comments.
================
Comment at: lldb/source/Target/Statistics.cpp:228
{"modules", std::move(json_modules)},
+ {"strings", string_stats.ToJSON()},
{"totalSymbolTableParseTime", symtab_parse_time},
----------------
clayborg wrote:
> "constStrings" maybe? or "stringPool"? "strings" makes it seem like we are
> tracking all strings in LLDB
>
> Do we want another top level key here for "memory" that we can slowly add
> things to? It would be nice to know how much memory symbols tables consume,
> DWARF data structures like the DIE vectors, and many others things. So maybe
> adding a "memory" key/value pair at the top here might be a good idea?
>
> ```
> "memory": {"strings": ..., "symtab": ..., "dwarf": .... }
> ```
I like that
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117914/new/
https://reviews.llvm.org/D117914
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
