labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
cool ================ Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1987 +NativeProcessLinux::GetSiginfo() const { + siginfo_t siginfo; + Status error = GetSignalInfo(GetCurrentThreadID(), &siginfo); ---------------- mgorny wrote: > labath wrote: > > I'd be better to outright allocate a memory buffer of the right size > > (`getNewUninitMemBuffer`), and directly write the data there. > I suppose there's no similar solution for the FreeBSD case where the > returned struct is a member of the temporary struct? Not with the current interface (and it's probably not worth changing it for it). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117113/new/ https://reviews.llvm.org/D117113 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits