labath added a comment. It seems to me like the ScriptedThread class would benefit from using the fallible constructor idiom. If you move all the potentially failing operations (initialization of the ScriptedThreadInterface instance?) into a (public) `static Expected<ScriptedThreadInterfaceSP> Create(...)` method, then the constructor will not need the funky by-ref error argument, and it will be able to access the thread id sufficiently early.
CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117076/new/ https://reviews.llvm.org/D117076 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits