mgorny added inline comments.

================
Comment at: 
lldb/test/API/functionalities/gdb_remote_client/amd64-fallback-regs.FileCheck:1
+CHECK-DAG: rax = 0x0807060504030201
+CHECK-DAG: rbx = 0x1817161514131211
----------------
labath wrote:
> I actually think it would be better if this was defined inline in the python 
> file, as then you could intersperse these lines with the definitions (which 
> you have already formatted in a way that makes this easy), and it would be 
> immediately obvious that the two lines describe the same data (modulo 
> endianness).
Using `self.match`, writing into a temporary file for FileCheck or do you have 
some other testing method on your mind?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116896/new/

https://reviews.llvm.org/D116896

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to