labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
I think this is in a pretty good shape now. Thanks for your patience. ================ Comment at: lldb/source/Symbol/Symbol.cpp:649 +/// The only tricky thing in this encoding is encoding all of the bits in the +/// bitfields. We use a trick to store all bitfields as a 16 bit value and we +/// do the same thing when decoding the symbol. There are test that ensure this ---------------- clayborg wrote: > labath wrote: > > I guess this isn't a "trick" anymore, just manual encoding of boolean > > bitfields into an int. > It is. I tried doing your approach of making an anonymous union and an > anonymous struct but I got a bunch of warnings that these were GNU extensions > and I feared that some buildbots would fail with warnings as errors. I also > didn't know if this would mess up the windows buildbots in case they didn't > support these. So to be safe I just manually encode stuff to be safe. Yes, I saw what you're doing, and that's fine. My point was that I would use the word "trick" to describe something clever/subtle/dangerous (which the original implementation was). This isn't tricky, its just tedious. :) But that's not a big deal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115324/new/ https://reviews.llvm.org/D115324 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
