DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM assuming that qemu passing on the SET/UNSET vars is what you've observed.
================
Comment at: lldb/source/Plugins/Platform/QemuUser/PlatformQemuUser.cpp:139
+ // The actual QEMU_(UN)SET_ENV variables should not be forwarded to the
+ // target.
+ if (!set_env.empty()) {
----------------
I glossed over this the first time, I assume you've observed this in testing.
My first assumption was that qemu wouldn't pass them on but hard to tell from
the sources. Probably some use case for it (emulating a second qemu-user?).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115246/new/
https://reviews.llvm.org/D115246
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
