labath added a comment.
I can't help the feeling that the boilerplate introduced by the enum
compression is just not worth the benefit it brings, but otherwise this looks
ok apart from the two inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h:90
+
+ // clang-format off
+ enum DWARFAttributeFlags : unsigned {
----------------
What's up with this?
I would hope that clang-format is able to reasonably format a simple enum
declaration like this.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:12-16
+#include "DWARFDIE.h"
#include "DWARFDefines.h"
#include "DWARFFormValue.h"
+#include "lldb/Core/Declaration.h"
+#include "lldb/Utility/ConstString.h"
----------------
revert this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114746/new/
https://reviews.llvm.org/D114746
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
