emaste added inline comments.

================
Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:67
       if (elf_header.Parse(data, &data_offset)) {
+        // Check whether we're dealing with a FreeBSD vmcore that needs
+        // to be handled via FreeBSDKernel plugin instead.
----------------
Maybe "FreeBSD full ELF vmcore" or such? We may have three different FreeBSD 
vmcore formats to deal with
1. kernel-generated ELF dumps (`sysctl debug.minidump=0`)
2. kernel-generated minidumps (`sysctl debug.minidump=1`)
3. minidump post-processed by (a fixed version of) 
https://reviews.freebsd.org/D19253


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114967/new/

https://reviews.llvm.org/D114967

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to