jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
Seems fine to me to break this into running and not running cases, but you
should use the right lldbutil method for the running case.
================
Comment at: lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py:40-43
+ lldbutil.run_to_breakpoint_make_target(self)
+
lldbutil.run_break_set_by_source_regexp(self, "// break here", "-f
main.cpp")
self.runCmd("run")
----------------
You don't need to do this in three steps, do you? Can't you just use
lldbutil.run_to_source_breakpoint? That will catch errors in running & hitting
the breakpoint which you don't check here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114819/new/
https://reviews.llvm.org/D114819
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
