DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land.
> All the comments etc came from that. Yeah it's a bit of a judgement call so it's a safe bet to add them and see what review thinks. I know for sure there are plenty of tests with way more cryptic expectations that don't have comments :) This LGTM. ================ Comment at: lldb/test/API/commands/memory/write/Makefile:2 +C_SOURCES := main.c +CFLAGS_EXTRAS := -std=c99 + ---------------- I was gonna say you can drop this but I see a few other tests with it, and it won't harm anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114544/new/ https://reviews.llvm.org/D114544 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
