ljmf00 added a comment.
Can you check now? If looks good, can you land it please?
================
Comment at: lldb/include/lldb/Symbol/Type.h:86
eEncodingIsAtomicUID, ///< This type is the type whose UID is
/// m_encoding_uid as an atomic type.
eEncodingIsSyntheticUID
----------------
teemperor wrote:
> teemperor wrote:
> > FWIW, we usually update the comments to something less >squished< such as:
> > ```
> > ///< This type is the type whose UID is m_encoding_uid
> > eEcodingIsUID.
> > /// This type is the type whose UID is m_encoding_uid with the const
> > qualifier added
> > eEncodingIsConstUID,
> > ```
> >
> > I think this patch is good as-is, but there would be bonus points for
> > fixing up the comment style :)
> I meant
> ```
> lang=c++
> /// This type is the type whose UID is m_encoding_uid
> eEcodingIsUID.
> /// This type is the type whose UID is m_encoding_uid with the const
> qualifier added
> eEncodingIsConstUID,
> ```
Done
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113604/new/
https://reviews.llvm.org/D113604
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
