labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:776 + constexpr auto T_max = std::numeric_limits<typename T::value_type>::max(); + dest = src >= 0 && static_cast<UU>(src) <= T_max ? src : fallback; } ---------------- `T` will always be unsigned here, right? May not hurt to add a `static_assert` for that, mainly to avoid people wondering if this logic is correct... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113519/new/ https://reviews.llvm.org/D113519 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
