JDevlieghere added inline comments.
================ Comment at: lldb/examples/python/scripted_process/stack_core_scripted_process.py:1 +import os,struct,signal + ---------------- mib wrote: > JDevlieghere wrote: > > This should live next to the test. I don't see a point of shipping this to > > users. > Do you mean the python script or the import statement ? In both case, I don't > think this we ship these to the users. I mean that `stack_core_scripted_process.py` shouldn't be under `lldb/examples` but should live in the test directory where it's used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
