labath added inline comments.
================ Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:558 +struct CompatibleArchs { + const char **archs = nullptr; ---------------- Is this any different from an `ArrayRef<const char *>`? ================ Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:564-565 + +#define COMPATIBLE_ARCHS(archs) \ + { archs, (sizeof(archs) / sizeof(const char *)) } + ---------------- This wouldn't be needed with arrayref, as it has an appropriate C array constructor CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113155/new/ https://reviews.llvm.org/D113155 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits