[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

This is great, thanks! (one question inline)



================
Comment at: 
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:1008
       }
-      result.SetStatus(lldb::eReturnStatusSuccessFinishResult);
-      return true;
+      success = true;
     }
----------------
I don't think `success` really works. Shouldn't the function only return `true` 
if none of the `arg_str`s failed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112945/new/

https://reviews.llvm.org/D112945

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits