labath marked 2 inline comments as done.
labath added inline comments.

================
Comment at: lldb/test/API/test_utils/TestBaseTest.py:1
+"""
+Test TestBase test functions.
----------------
teemperor wrote:
> Could we move this file into `test_utils/build` or some other subdir? Then I 
> can also make the few other 'test'-tests their own subdir of `test_utils` 
> (which seems like a good place for all of this).
I've created a `base` folder for the `Base` class. It could either be a root of 
an additional hierarchy or we can shove all Base tests there. I'd hope it's the 
latter, as one can go quite far by just passing CXX_SOURCE to the make 
invocations, and these aren't particularly complex tests or inferiors.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112212/new/

https://reviews.llvm.org/D112212

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to