labath added a comment. Maybe a quick unit test which send like 1MB of data in a single call or something similar?
================ Comment at: lldb/include/lldb/Core/Communication.h:195 /// The actual write function that attempts to write to the communications /// protocol. /// ---------------- It might be worthwhile to emphasize that this will happily return after a partial write and point the reader to WriteAll if he wants to write everything. ================ Comment at: lldb/source/Core/Communication.cpp:29 #include <memory> +#include <thread> ---------------- delete ================ Comment at: lldb/source/Core/Communication.cpp:200 + total_written += written; + if (status != eConnectionStatusSuccess || total_written >= src_len) + break; ---------------- It looks like this could be a do-while loop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112169/new/ https://reviews.llvm.org/D112169 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
