labath added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:646
+ bpno,
+ expected_locations = -1,
+ expected_hit_count = -1,
----------------
`None` would be more pythonic
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:663-664
+ if(expected_locations > -1):
+ test.assertTrue(expected_locations == bkpt.GetNumLocations(),
+ "Expecting {} locations, got
{}.".format(expected_locations, bkpt.GetNumLocations()))
+
----------------
If you replace `assertTrue(foo == bar)` with `assertEquals(foo, bar)` then you
get the failure message for free.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111899/new/
https://reviews.llvm.org/D111899
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits