labath added a comment.

This looks reasonable to me. In case the url does not specify port parameters, 
it might be better to set them to known sane defaults instead of leaving them 
unchanged. That way lldb and lldb-server could "just connect". However, I don't 
know much about serial ports so I'm leaving that up to you.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111355/new/

https://reviews.llvm.org/D111355

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to