JDevlieghere added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684
+ llvm::SmallVector<llvm::StringRef, 3> matches;
+ if (g_swiftlang_version_regex.Execute(producer, &matches)) {
+ m_producer_version.tryParse(matches[1]);
----------------
For consistency with the code below, should we first check if
`roducer.contains("swift")` and then execute the regex? Otherwise the
indentation on the line below is off.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111278/new/
https://reviews.llvm.org/D111278
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
