labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/source/Plugins/ABI/X86/ABIX86.h:12
-#include "lldb/Target/ABI.h"
-
-class ABIX86 : public lldb_private::MCBasedABI {
+class ABIX86 {
public:
----------------
Now it's weird that this class is in no relation to the ABI class, nor to the
individual ABIXXX_YYY subclasses. Maybe lets insert it into the hierarchy (as a
common superclass of ABIX86_i386 and ABIX86_64). Even if it's initially empty,
I can imagine one could eventually put some common x86 code there.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111216/new/
https://reviews.llvm.org/D111216
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
