mgorny marked an inline comment as done. mgorny added a comment. In D110962#3039428 <https://reviews.llvm.org/D110962#3039428>, @labath wrote:
> Have you considered using the PseudoTerminal class to create the ptys ? That's really stupid of me but for some reason I've assumed that if LLDB had any pty-related logic, it'd live in `Terminal.h` ;-). ================ Comment at: lldb/unittests/Host/CMakeLists.txt:27 +if (LLDB_ENABLE_TERMIOS AND + CMAKE_SYSTEM_NAME MATCHES "Darwin|FreeBSD|Linux|NetBSD|OpenBSD") + list(APPEND FILES ---------------- labath wrote: > mgorny wrote: > > FTR, I've tested it on FreeBSD and Linux so far. NetBSD in progress. Darwin > > and OpenBSD support is based on what I've found in gnulib but explicit > > testing would be helpful. > At this point, I'd just go with `NOT windows` If I'm using `PseudoTerminal`, then I guess I don't need the platform check at all (and 'not Windows' is implied by `LLDB_ENABLE_TERMIOS`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110962/new/ https://reviews.llvm.org/D110962 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
