[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

Just a nitpick.



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3564
+      // If we start a new block, compute a new block context and recurse.
+      Block *block = sc.function->GetBlock(true).FindBlockByID(die.GetID());
+      if (block == nullptr) {
----------------
`/*can_create=*/true`


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3573
+        if (concrete_block_die)
+          block = sc.function->GetBlock(true).FindBlockByID(
+              concrete_block_die.GetID());
----------------
`/*can_create=*/true`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110570/new/

https://reviews.llvm.org/D110570

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits