labath added a comment. The test looks mostly fine. I made some comments on how to make it compatible with windows. I'm not sure if it would be enough to make it run there, but I think it has a fair chance. I might just let it run and then disable it if it turns out to be failing.
================ Comment at: lldb/test/API/functionalities/dlopen/TestDlopen.py:14-16 + lib_name = 'liblib_b.so' + if self.platformIsDarwin(): + lib_name = 'liblib_b.dylib' ---------------- see `self.platformContext.shlib_prefix/extension` for how to portably build this path (TestLoadUnload uses a mixture of these, as only those tests which work/make sense on windows have been updated). ================ Comment at: lldb/test/API/functionalities/dlopen/main.cpp:8-10 + if (argc == 2) { + solib = argv[1]; + } ---------------- why this argument dance? can we remove it? ================ Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26 + // dlopen the 'liblib_b.so' shared library. + void* h = dlopen(solib, RTLD_LAZY); + assert(h && "dlopen failed?"); ---------------- see dylib.h and the functions within (the inferior of TestLoadUnload uses them) for a windows-compatible way to load shared libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits