mstorsjo added a comment. In D109777#3003312 <https://reviews.llvm.org/D109777#3003312>, @DavidSpickett wrote:
> One thing that I forgot to ask, are there already tests that cover the > scenario the bug reported? No idea - this fixes a sequence of `b <somesymbol>`, `run`, `step`, i.e. fairly trivial/basic breakpoint functionality. (It fixes it entirely on ARM64; on ARM there's other issues due to the thumb bit offset that I haven't had time to fix, but the aspects that this patch touches should be correct for ARM at least.) > Good chance there are but they only run on x86 due to the available bots. We > (Linaro) are working to get more tests running on WoA bots so this would be > covered eventually. That'd be great. I haven't ever run the LLDB testsuite properly on Windows on ARM - my only WoA hardware is in the absolute lowest end (Snapdragon 835) so I only cross compile things and test on the target device manually - doing cross testing of LLDB is tricky to say the least, and I wouldn't want to try to actually build LLDB and run the testsuite natively on that hardware... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109777/new/ https://reviews.llvm.org/D109777 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
