mgorny added a comment.

In D108554#2993766 <https://reviews.llvm.org/D108554#2993766>, @labath wrote:

> I'm not sure we should be preserving this behavior for the native register 
> context. User-provided strings should not make it there, and code should 
> really be retrieving the registers in some other way (like via the 
> LLDB_REGNUM_GENERIC_*** constants).

Could you rephrase this comment to indicate the requested change, if any? ;-)

> It would also be nice to follow this up by actually removing the generic 
> altnames from register definitions, for cases where they don't match 
> architecturally defined names.

That was roughly my plan, presuming you like the idea. Should I include this in 
the same commit or separately for each platform?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108554/new/

https://reviews.llvm.org/D108554

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to