MaskRay added inline comments.
================
Comment at:
lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py:16
+ exe = "/lib64/ld-linux-x86-64.so.2"
+ if(os.path.exists(exe)):
+ target = self.dbg.CreateTarget(exe)
----------------
================
Comment at:
lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py:38
+ self.assertEqual(process.GetState(), lldb.eStateStopped)
+
self.assertIn("get_signal_crash",thread.GetFrameAtIndex(0).GetDisplayFunctionName())
+ process.Continue()
----------------
space after comma
================
Comment at:
lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py:45
+
self.assertIn("get_signal_crash",thread.GetFrameAtIndex(1).GetDisplayFunctionName())
+
+
----------------
delete blank lines
================
Comment at: lldb/test/API/functionalities/dyld-launch-linux/signal_file.h:1
+int get_signal_crash(void);
----------------
C++ doesn't typically use `(void)`. Just use `()`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108061/new/
https://reviews.llvm.org/D108061
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
