shafik added inline comments.
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6505
if (idx_is_valid) {
- const clang::ReferenceType *reference_type =
- llvm::cast<clang::ReferenceType>(GetQualType(type).getTypePtr());
- CompilerType pointee_clang_type =
- GetType(reference_type->getPointeeType());
+ CompilerType pointee_clang_type;
+
----------------
teemperor wrote:
> I really like the idea of reusing the TypeSystemClang functions here (we
> should do this everywhere I think). FWIW, I think this can all just be
> `CompilerType pointee_clang_type = GetNonReferenceType(type);` From the code
> below `GetPointeeType` would also work. We already call the variable here
> `pointee` type so I don't think calling references pointers here will hurt
> too much, so I think both is fine.
I tried `GetNonReferenceType(type).GetPointeeType()` but I get back an empty
`CompilerType` it looks like it is doing almost exactly the same thing as the
previous code:
`(*this)->getAs<ReferenceType>()`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108717/new/
https://reviews.llvm.org/D108717
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
