wallace created this revision.
wallace added reviewers: teemperor, clayborg.
Herald added a reviewer: shafik.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
D103172 <https://reviews.llvm.org/D103172> has a couple of mistakes when
modifying a variable outside the for loop. I really don't know how to make a
test for this, so feel free to commandeer this diff and finish it.
With this path I was able to set breakpoint on a complex binary I have.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D107434
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -3477,7 +3477,8 @@
UniqueCStringMap<DWARFDIE> dst_name_to_die;
UniqueCStringMap<DWARFDIE> src_name_to_die_artificial;
UniqueCStringMap<DWARFDIE> dst_name_to_die_artificial;
- for (DWARFDIE src_die : src_class_die.children()) {
+ for (DWARFDIE src_die_ : src_class_die.children()) {
+ src_die = src_die_;
if (src_die.Tag() == DW_TAG_subprogram) {
// Make sure this is a declaration and not a concrete instance by looking
// for DW_AT_declaration set to 1. Sometimes concrete function instances
@@ -3495,7 +3496,8 @@
}
}
}
- for (DWARFDIE dst_die : dst_class_die.children()) {
+ for (DWARFDIE dst_die_ : dst_class_die.children()) {
+ dst_die = dst_die_;
if (dst_die.Tag() == DW_TAG_subprogram) {
// Make sure this is a declaration and not a concrete instance by looking
// for DW_AT_declaration set to 1. Sometimes concrete function instances
Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -3477,7 +3477,8 @@
UniqueCStringMap<DWARFDIE> dst_name_to_die;
UniqueCStringMap<DWARFDIE> src_name_to_die_artificial;
UniqueCStringMap<DWARFDIE> dst_name_to_die_artificial;
- for (DWARFDIE src_die : src_class_die.children()) {
+ for (DWARFDIE src_die_ : src_class_die.children()) {
+ src_die = src_die_;
if (src_die.Tag() == DW_TAG_subprogram) {
// Make sure this is a declaration and not a concrete instance by looking
// for DW_AT_declaration set to 1. Sometimes concrete function instances
@@ -3495,7 +3496,8 @@
}
}
}
- for (DWARFDIE dst_die : dst_class_die.children()) {
+ for (DWARFDIE dst_die_ : dst_class_die.children()) {
+ dst_die = dst_die_;
if (dst_die.Tag() == DW_TAG_subprogram) {
// Make sure this is a declaration and not a concrete instance by looking
// for DW_AT_declaration set to 1. Sometimes concrete function instances
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
