teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
Thanks! This LGTM itself, but I would prefer if we could remove that define in this commit and remove the redundant Config.h includes in another (so, the first version of this patch LGTM). Removing Config.h is always a bit icky as it will just silently disable all the `#if feature` code in case it's actually needed. IIUC you checked all the including files, but there are also downstream folks who will have probably an easier time bisecting potential fallout from this when it's a dedicated commit with a clear '[lldb] Remove redundant Config.h includes' as a title. (Also unrelated: I think quite a few of the files here don't actually need anything from sys/types.h? We could probably just remove a bunch of this stuff all-together as a followup) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107338/new/ https://reviews.llvm.org/D107338 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
