Mostly I was reacting to your saying the "fully qualified name" idea was too much of a C++ specific thing and didn't belong in the Language abstraction. That doesn't seem to me right. Swift has module names & class namespaces, etc. And you might want to dial up all methods with some base name or narrow down to the one implemented by a class or module in the same way. And we make the distinction between matching base names & qualified names in most of our searches; so this does seem a generally useful accessor.
The name was a way to phrase the access that made sense of it as a general thing, but I'm not stuck on that name . And you didn't make any actual moves to put it just in the C++ Language, so I'm doubly fine with that... It does seem odd to stick "Demangled" in the name as that does seem more an implementation detail. But my main point was that I did think this belongs in the Language plugin, so I'm good. Jim > On Jul 26, 2021, at 12:39 PM, Alex Langford via Phabricator > <revi...@reviews.llvm.org> wrote: > > bulbazord added a comment. > > ping! > > @jingham I can change the name to `GetFullyQualifiedBaseName` if needed. Is > there anything else here that should be changed or addressed? > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D105215/new/ > > https://reviews.llvm.org/D105215 > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
