clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere.
Just switch to unique_ptr and this will be good to go. ================ Comment at: lldb/include/lldb/lldb-forward.h:445 typedef std::shared_ptr<lldb_private::Trace> TraceSP; +typedef std::shared_ptr<lldb_private::TraceExporter> TraceExporterSP; typedef std::unique_ptr<lldb_private::TraceCursor> TraceCursorUP; ---------------- Make unique_ptr since the exporters will be short lived. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106501/new/ https://reviews.llvm.org/D106501 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
