JDevlieghere added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2121
+ return SendErrorResponse(llvm::make_error<StringError>(
+ inconvertibleErrorCode(), "Malformed thread-id"));
+
----------------
mgorny wrote:
> JDevlieghere wrote:
> > Would it be useful to say "Malformed thread-id for process-id {}"?
> In this context, 'thread-id' is GDB protocol jargon for 'PID and/or TID'. So
> if it's malformed, then we don't really have a process ID here. I suppose I
> could try replacing 'thread-id' with something more verbose but I'm not sure
> if this is the kind of error end users will be dealing with.
Fair enough. Thanks for the explanation!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100261/new/
https://reviews.llvm.org/D100261
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
