teemperor added a comment. In D104856#2838526 <https://reviews.llvm.org/D104856#2838526>, @jankratochvil wrote:
> In D104856#2838515 <https://reviews.llvm.org/D104856#2838515>, @teemperor > wrote: > >> (Nit: this is from the Linux manpage but this code is only compiled on >> Darwin). > > Why do you think so? I haven't tried to build it on OSX but according to GIT > the last use of this function was removed by Re-landing IPv6 support for > LLDB Host > <https://github.com/llvm/llvm-project/commit/1182779917b3c1681274e6feaa4d36e51b7e142e>. The file is part of `debugserver` which is Darwin exclusive and is also only compiled/used when you're on Darwin. It's also kind of its own thing: it isn't using LLVM libraries such as ADT and we usually leave it out of larger refactorings because it's kind of in "maintenance-only" mode IIRC. Anyway, this patch is probably fine but I added Jason as a reviewer because he knows the debugserver best. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/ https://reviews.llvm.org/D104856 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
