teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed.
There are two places where this isn't redundant (see inline comments) but otherwise this LGTM. Thanks! ================ Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:892 if (command.GetArgumentCount() <= 0) { result.GetErrorStream().Printf("error: required argument missing; " "specify your program variable to watch " ---------------- `AppendErrorWithFormat` otherwise the status isn't changed. ================ Comment at: lldb/source/Commands/CommandObjectWatchpoint.cpp:915 if (command.GetArgumentCount() != 1) { result.GetErrorStream().Printf( "error: specify exactly one variable to watch for\n"); ---------------- Same as above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104448/new/ https://reviews.llvm.org/D104448 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits