teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed.
Thanks for writing tests, it's really appreciated! FWIW, I think that you can just check in new tests without having to go through a full review (unless you do want feedback for it). Having said that, would it be possible to maybe just extend the TestUnicodeSymbols.py test for the breakpoint part? You could just try setting a breakpoint and see if it gets resolved, this way the test doesn't have to start a new process (which is really expensive). There is also already a test for unicode variables (`TestUnicodeInVariable.py`)so this is redundant IIUC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
