tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.
LGTM! My only comments are about wording in some of the code comments.
================
Comment at: lld/wasm/Symbols.h:419
+// attribute and a type. Currently the attribute can only specify that the tag
+// is for the exception.
//
----------------
================
Comment at: lld/wasm/Symbols.h:421
//
-// Event tags are values to distinguish different events. For exceptions, they
-// can be used to distinguish different language's exceptions, i.e., all C++
-// exceptions have the same tag. Wasm can generate code capable of doing
-// different handling actions based on the tag of caught exceptions.
+// In exception handling, tags are values to distinguish different exceptions.
+// For exceptions, they can be used to distinguish different language's
----------------
================
Comment at: lld/wasm/Symbols.h:422
+// In exception handling, tags are values to distinguish different exceptions.
+// For exceptions, they can be used to distinguish different language's
+// exceptions, i.e., all C++ exceptions have the same tag. Wasm can generate
----------------
================
Comment at: lld/wasm/Symbols.h:423-425
+// exceptions, i.e., all C++ exceptions have the same tag. Wasm can generate
+// code capable of doing different handling actions based on the tag of caught
+// exceptions.
----------------
================
Comment at: lld/wasm/Symbols.h:427
//
-// A single EventSymbol object represents a single tag. C++ exception event
-// symbol is a weak symbol generated in every object file in which exceptions
-// are used, and has name '__cpp_exception' for linking.
-class EventSymbol : public Symbol {
+// A single TagSymbol object represents a single tag. C++ exception symbol is a
+// weak symbol generated in every object file in which exceptions are used, and
----------------
================
Comment at: lld/wasm/Symbols.h:429
+// weak symbol generated in every object file in which exceptions are used, and
+// has name '__cpp_exception' for linking.
+class TagSymbol : public Symbol {
----------------
================
Comment at: lld/wasm/SyntheticSections.h:176
+// contains information on what kind of tag it is (e.g. exception) and the type
+// of values contained in a single tag object. (In wasm, a tag can contain
// multiple values of primitive types. But for C++ exceptions, we just throw a
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104423/new/
https://reviews.llvm.org/D104423
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
