mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
Left few comments regarding the phrasing but LGTM! Thanks for doing it!
================
Comment at: lldb/bindings/interface/SBType.i:372
+ %feature("docstring",
+ "Returns the underlying pointer type.
+
----------------
Could you keep the same style as the previous function docstring ?
================
Comment at: lldb/bindings/interface/SBType.i:411
+ %feature("docstring",
+ "Returns the underlying type of a typedef.
+
----------------
Same
================
Comment at: lldb/bindings/interface/SBType.i:427
+ %feature("docstring",
+ "Returns the underlying type of a reference type.
+ If this type is a reference as designated by `IsReferenceType`, then the
----------------
Same + newline
================
Comment at: lldb/bindings/interface/SBType.i:443
+ %feature("docstring",
+ "Returns the unqualified version of this type.
+
----------------
Same
================
Comment at: lldb/bindings/interface/SBType.i:458
+ %feature("docstring",
+ "Returns the underlying integer type if this is an enumeration type.
+
----------------
Same
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103454/new/
https://reviews.llvm.org/D103454
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
