jingham added a comment.

The idea seems good, but I'm not sure how you are going to extend it?  
"Selector" seems a pretty ObjC specific term to me.  Will this be what you use 
to get the "method name" part of the C++ names?  That would look a bit odd to 
me, but OTOH having a GetSelector in all the subclasses, most of which don't 
have selectors also seems a little odd.  This might be solved by just thinking 
of a better name, however.  Also note, in the C++ case, it would be useful to 
distinguish between the method name, like Bar in Foo::Bar, and the fully 
qualified method name (like Bar(int, double) in Foo::Bar(int, double).  That 
might effect the choice of names.  The selector is the equivalent of a C++ 
fully qualified method name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103210/new/

https://reviews.llvm.org/D103210

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to