[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

[Khem Raj via Phabricator via lldb-commits]

raj.khem created this revision.
raj.khem added a project: LLDB.
Herald added subscribers: JDevlieghere, atanasyan, arichardson, sdardis.
raj.khem requested review of this revision.
Herald added a subscriber: lldb-commits.

This helps fixing lldb-server build regression

> /mnt/b/yoe/master/build/tmp/work/mips32r2-yoe-linux-musl/clang/13.0.0-r0/recipe-sysroot-native/usr/bin/mips-yoe-linux-musl/mips-yoe-linux-musl-ld:
>  lib/liblldbPluginProcessLinux.a(NativeThreadLinux.cpp.o): in function 
> `lldb_private::process_linux::NativeThreadLinux::NativeThreadLinux(lldb_private::process_linux::NativeProcessLinux&,
>  unsigned long long)':
> NativeThreadLinux.cpp:(.text._ZN12lldb_private13process_linux17NativeThreadLinuxC2ERNS0_18NativeProcessLinuxEy+0x74):
>  undefined reference to 
> `lldb_private::process_linux::NativeRegisterContextLinux::CreateHostNativeRegisterContextLinux(lldb_private::ArchSpec
>  const&, lldb_private::process_linux::NativeThreadLinux&)'
> /mnt/b/yoe/master/build/tmp/work/mips32r2-yoe-linux-musl/clang/13.0.0-r0/recipe-sysroot-native/usr/bin/mips-yoe-linux-musl/mips-yoe-linux-musl-ld:
>  
> NativeThreadLinux.cpp:(.text._ZN12lldb_private13process_linux17NativeThreadLinuxC2ERNS0_18NativeProcessLinuxEy+0x7c):
>  undefined reference to 
> `lldb_private::process_linux::NativeRegisterContextLinux::CreateHostNativeRegisterContextLinux(lldb_private::ArchSpec
>  const&, lldb_private::process_linux::NativeThreadLinux&)'
> clang-13: error: linker command failed with exit code 1 (use -v to see 
> invocation)




Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D102872

Files:
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h


Index: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
===================================================================
--- lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
+++ lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
@@ -26,7 +26,8 @@
   // variant should be compiled into the final executable.
   static std::unique_ptr<NativeRegisterContextLinux>
   CreateHostNativeRegisterContextLinux(const ArchSpec &target_arch,
-                                       NativeThreadLinux &native_thread);
+                                       NativeThreadLinux &native_thread)
+                                      { return 0; }
 
   // Invalidates cached values in register context data structures
   virtual void InvalidateAllRegisters(){}



Index: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
===================================================================
--- lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
+++ lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.h
@@ -26,7 +26,8 @@
   // variant should be compiled into the final executable.
   static std::unique_ptr<NativeRegisterContextLinux>
   CreateHostNativeRegisterContextLinux(const ArchSpec &target_arch,
-                                       NativeThreadLinux &native_thread);
+                                       NativeThreadLinux &native_thread)
+	                               { return 0; }
 
   // Invalidates cached values in register context data structures
   virtual void InvalidateAllRegisters(){}

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits