Author: Raphael Isemann
Date: 2021-05-20T18:00:02+02:00
New Revision: 8ebaa195015dfd56f8413c43aa8f6d78ea7e6b30

URL: 
https://github.com/llvm/llvm-project/commit/8ebaa195015dfd56f8413c43aa8f6d78ea7e6b30
DIFF: 
https://github.com/llvm/llvm-project/commit/8ebaa195015dfd56f8413c43aa8f6d78ea7e6b30.diff

LOG: [lldb] Adjust DumpDataExtractorTest.Formats for Windows

Not sure if that's the ostringstream or our conversion code, but this is
returning the wrong results on Windows.

Added: 
    

Modified: 
    lldb/unittests/Core/DumpDataExtractorTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Core/DumpDataExtractorTest.cpp 
b/lldb/unittests/Core/DumpDataExtractorTest.cpp
index b678e62d8834..cfd24ff41491 100644
--- a/lldb/unittests/Core/DumpDataExtractorTest.cpp
+++ b/lldb/unittests/Core/DumpDataExtractorTest.cpp
@@ -185,7 +185,13 @@ TEST(DumpDataExtractorTest, Formats) {
            lldb::Format::eFormatVectorOfFloat16, "{-6.09756e-05 6.09756e-05}");
   // Some normal numbers.
   TestDump(std::vector<uint16_t>{0b0100001001001000},
-           lldb::Format::eFormatVectorOfFloat16, "{3.14062}");
+           lldb::Format::eFormatVectorOfFloat16,
+#ifdef _WIN32
+           // FIXME: This should print the same on all platforms.
+           "{3.14063}");
+#else
+           "{3.14062}");
+#endif
   // Largest and smallest normal number.
   TestDump(std::vector<uint16_t>{0x0400, 0x7bff},
            lldb::Format::eFormatVectorOfFloat16, "{6.10352e-05 65504}");


        
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to